dongyan
dongyan
Can anybody help add reviewers? (Also approve running workflows)
PTAL @alainfrisch @Drup @pmetzger
> I think I would be easier if your trace was maintaining pairs of pos, instead of pos + len. Thanks for your suggestions! Let me do some fixes.
> I can't really comment on the implementation but, for the API, is there a benefit in exporting `offset`/`length` vs simply binding the resulting match string? The bindings can be...
> I would be useful to write test (as expect test (ppx_expect) maybe). The examples are currently not testing enough. Sure, I'll refactor the test later. > ``` > Op...
> ``` > Op aaaab - bb > EOF > ``` @hhugo This one is fixed. You may check the expect test result. I will update the implementation details in...
With the information of matched lexeme and DFA path, we have to restore the NFA path. Tracing back the NFA path, we know from the NFA node about when an...
> Could you give more details about the current implementation ? Why is it done this way ? Can't we update positions as we traverse the automation, instead of doing...
@hhugo Thanks for your considerate suggestions! Let me do it one by one and start from merging the alias offsets. > ocamllex has some optimization: > > ``` > rule...
@pmetzger Thanks for the link!