Dylan Hunn

icon indicating a website link dylanhunn.com

icon company Google icon location San Francisco icon location I'm a maintainer of the open-source Angular Framework. Software engineer at Google, based in San Francisco. #Angular 🏳️‍🌈🏙️🚀

Results 185 comments of Dylan Hunn

Forms should throw error if two or more NgModels appear in form with the same name

We'd likely accept a contribution in this area, and it's good for a first-time contributor. The message would go in `forms/src/directives/template_driven_errors.ts`, and the check would be somewhere in `forms/src/directives`.

Forms should throw error if two or more NgModels appear in form with the same name

@GrizzlyEnglish @phalgunv If one of you ends up implementing this, here is a code example of how to throw an Angular `RuntimeError`: [Link to example.](https://github.com/angular/angular/blob/main/packages/forms/src/directives/radio_control_value_accessor.ts#L22) As in the example, you...

Forms should throw error if two or more NgModels appear in form with the same name

Also @phalgunv I'm sorry I didn't see your request for setup help above. Long story short, it's much easier to get the build working on MacOS or Linux. I'd encourage...

Forms should throw error if two or more NgModels appear in form with the same name

Glad to hear you're working on this! No rush, but please send it my way and/or ping me when you want a review!

Forms should throw error if two or more NgModels appear in form with the same name

@GrizzlyEnglish I have reopened #46994. Is it ready for review? Edit: yes; convo continued on the PR

feat(forms): add error when adding control with dupe name to form

I have reopened as requested in #13993. Would you like me to review this as-is? @GrizzlyEnglish

feat(forms): add error when adding control with dupe name to form

Great. My main concern on first glance is making sure this a non-breaking change. I'll get back to you soon with more specific comments.

Reactive form control `root` points to nothing or itself.

Hello! I am not entirely clear on what you're trying to do. Would you be able to provide a reproduction and example on StackBlitz?

FormGroup.updateValueAndValidity() add option to affect descendants

In general, validation state flows from the bottom to the top of a form structure, so recalculating from the top-down is a bit of a code smell. I'd be curious...

FormGroup.updateValueAndValidity() add option to affect descendants

@Leccho Since the controls depend on each other, why not just put the validator on the enclosing group? That would allow you to achieve something similar -- of course the...