Dylan Copeland

Results 75 comments of Dylan Copeland

Thank you @nbeams for looking into this issue. I used the latest `develop` branch commit as of this morning: 7dc18e2de6c7822ac434092a60653c3d2af79d03

> For the build error with Ginkgo, it will take some changes in the MFEM wrappers to address. I also encountered some more deprecation warnings that are newer than the...

@pazner Thank you for the elegant example repo. I like this approach and think it could work for MFEM. Conveniently, we would not need to change the use of `fptype`....

PRs with `double` keep getting merged to master. Could we please prioritize the review of this PR?

I tried unsuccessfully to reproduce the issue. There may be a problem in some cases, but we may need help to find such cases. Here is what I tried: 1....

I just tried the same procedure with `data/fichera.mesh` and `data/toroid-hex.mesh` (which has a hole), and the attributes were still reproduced correctly.

Thanks @IdoAkkerman for the recent fixes. The miniapps are converging now. I am close to approving, but there are still a few old comments to be addressed from December that...

@sebastiangrimberg could you please add a parallel unit test that fails in master and passes in this branch?

@sebastiangrimberg it would nice to have a unit test if it doesn't take too much work, but I agree that it is not absolutely necessary. There are lots of good...

> Are the new libROM function interfaces backward compatible? Namely, if the time and timestep values are not removed from existing function calls, will that produce an error? Or have...