Laghos icon indicating copy to clipboard operation
Laghos copied to clipboard

Update for libROM PR 261

Open dylan-copeland opened this issue 1 year ago • 2 comments

dylan-copeland avatar Feb 23 '24 03:02 dylan-copeland

Are the new libROM function interfaces backward compatible? Namely, if the time and timestep values are not removed from existing function calls, will that produce an error? Or have they been kept as default argument variables that are simply not used within libROM?

cval26 avatar Feb 29 '24 23:02 cval26

Are the new libROM function interfaces backward compatible? Namely, if the time and timestep values are not removed from existing function calls, will that produce an error? Or have they been kept as default argument variables that are simply not used within libROM?

The interface had a breaking change in libROM PR 261, i.e. it is not backward compatible. It is necessary to remove the time and timestep from the function calls, in order to compile. The changes are not too bad, as seen in this PR.

dylan-copeland avatar Mar 01 '24 01:03 dylan-copeland