Marcin Pączkowski

Results 611 comments of Marcin Pączkowski

I marked this as "API change" so that we note this in the changelog. @telephon please merge at your leisure, thanks!

@JordanHendersonMusic what's the status of your review?

Thanks for working on this. I personally think that we should have a way of using quarks without OS-installed git, particularly on macOS and Windows. Just so you know, concerns...

@smoge yes, these are all valid points, and something to consider when we discuss the future of package management in SC. My point with security was more about the possible...

> Wouldn't it be better to block internet access in the help browser? SC provides the `WebView` class, running using the same engine as the help browser - web browsing...

I am hoping to take a look at the cmake part of this! Just FYI.

Hm, I know adding primitives is debatable. I guess - if this works, it could be a nice addition for 3.15... but if we will introduce a package manager by...

I'd like to share my progress here for reference: TL;DR here's the branch with libgit building on all platforms: https://github.com/dyfer/supercollider/tree/topic/lib-git-cmake-mp-rebased-2 (sorry it's squashed into a [single commit](https://github.com/dyfer/supercollider/commit/38e7cf7c6a6e3f79ddc7e6bd7b9f8d9602a216c5), I had problems...

Okay, to clean this up... It turns out that much of the messy cmake code inclusion was due to libgit2 missing a workaround for xcode and static lib creation. Here's...

There's a number of similar issues filed: - https://github.com/supercollider/supercollider/issues/3531 - https://github.com/supercollider/supercollider/issues/4812 - possibly related: https://github.com/supercollider/supercollider/issues/4413 - possibly related: https://github.com/supercollider/supercollider/issues/6082 There might be some timing differences between MSVC and other compilers...