Dave Kerr

Results 185 issues of Dave Kerr

**Challenges** - Opening a modal does not change the focus. This generally requires manual workaround to ensure a solid user experience. **Solution** Add a `showModal` option which allows the caller...

enhancement

It would be extremely useful to document how unit testing works with Angular Modal Service.

It would be great to support Angular 2. Step 1 is to detail the proposed API. See: - https://github.com/dwmkerr/angular-modal-service/issues/186 - https://github.com/dwmkerr/angular-modal-service/issues/179

Might be easier to just do: ```js console.error('An error occurred labelling the icon: ${err}'); ``` Another improvement would be to perhaps standardise the error logging a little, to make sure...

See `bin/app.icon.js`: ``` operations.push(errorIfMissing(icon, `Source file '${icon}' does not exist. Add the file or specify source icon with the '--icon' parameter.`)); ``` This is a huge smell, there is a...

Node 6 reaches end of life 2019-04-30, so let's bump to 8. This will greatly simplify code as we can use `async/await`.

Something like this would be great: ![image](https://user-images.githubusercontent.com/1926984/56713806-624bbf80-6765-11e9-9864-afb31309c778.png) Especially if we can show: - Labels - Adaptive - Android/iOS At the same time it would be good to do a new...

There is the `ic_launcher_web` icon which is used for the app store. We could also update this one. https://stackoverflow.com/questions/13895390/what-does-the-ic-launcher-web-png-in-my-project-root-do

See #71. We now generate round icons - but it might be better to support an `icon.round.png` image as a template for this, in a similar way to adaptive icon....