dvz

Take a look at the value for the `url_before_redirect` form field (basing on `$_SERVER['HTTP_REFERER']`) on the _Accept_ page, respected if this condition is met: https://github.com/kawaii/mybb-amnesia/blob/15e2115/inc/plugins/amnesia/hooks_frontend.php#L307

It should redirect to _Board URL_, unless it's not not set properly; another reason for a loop is an update date set in the future (in this case the _Accept_...

> The main issue with the current system that I see in practice is that upgrades require quite a bit of knowledge from admins because of how updates are handled....

Would it be better to handle uploaded files as regular attachments? That would make it an interface improvement without introducing new kinds of uploads and locations watch out for. The...

Yes, we always want to avoid breaking changes, and only introduce them with new series. This should be done with either 1.9.0 or 1.10.0.

This bug may be used as a feature - we could add a way to keep displaying original thumbnails (perhaps when the setting is empty).

Looks like these are still unaddressed (https://github.com/mybb/mybb/issues/4240#issuecomment-775511385): > - Permission handling for thumbnails need to be added to the attachment.php file. > - Some users might decide to embed attachments...

The Pull Request only replaces calls to `errorHandler` - future improvements may include replacing the usage of: - the `$error_reporting` property, defined in DB driver classes - `$hide_errors` parameters of...

> [...] or update all core calls (which, while tedious, would be my preferred approach - then we could use prepared statements for raw queries too). IMO it's better to...

> The query SQL to DROP SEQUENCE is using single quotes so the variables in it won't get expanded. ~~These seem to be literal `'`, with the whole string in...