Denis Voituron

Results 109 comments of Denis Voituron

Updated in PR #2310. Will be included in the next Release.

Yes. Good idea. Can you update the `Readme.md` with this improvement?

That might be a good idea (which I don't do). Do you know why?

@vnbaaij @adamint @SwatiJo Sorry, I was off yesterday. I think that we worked on this "feature" a few weeks ago, to find [a workaround in the FluentUI-Blazor lib (PR 1800)](https://github.com/microsoft/fluentui-blazor/pull/1800)....

After some further research, it seems that the web component `fluent-toolbar` changes all sub-elements with `tabindex="-1"`, except the one it's on. And that it overloads the passage from one element...

I think you can bypass these changes, adding this Cascading property in your new column code. ```csharp [CascadingParameter] internal InternalGridContext InternalGridContext { get; set; } = default!; ```

> Ok but the InternalGridContext Is internal Indeed ;-)

> IMO InternalGridContext could be deleted and move properties/methods to FluentDataGrid. FluentDataGrid is found in CascadingParameter, or change visibility InternalGridContext Nop. `InternalGridContext` exists to centralize some internal properties. The next...

Interesting. Why not use `OnClosing`? Possibly by adding a `Cancelled` parameter. I also find the `On` suffix indicates that this is an `EventCallback`, which is not the case.

You could add this parameter to a inherited class of DialogInstance (like `DialogInstanceClosing`). My question is more: why to have similar "events". A `Func` like you did can solve this...