fluentui-blazor icon indicating copy to clipboard operation
fluentui-blazor copied to clipboard

[DataGrid] ColumnBase improve access information

Open franklupo opened this issue 1 year ago • 10 comments

To create columns outside this library I need information that isn't there now.

franklupo avatar Jul 24 '24 09:07 franklupo

I think you can bypass these changes, adding this Cascading property in your new column code.

[CascadingParameter]
internal InternalGridContext<TGridItem> InternalGridContext { get; set; } = default!;

dvoituron avatar Jul 24 '24 09:07 dvoituron

I think you can bypass these changes, adding this Cascading property in your new column code.

[CascadingParameter]
internal InternalGridContext<TGridItem> InternalGridContext { get; set; } = default!;

Ok but the InternalGridContext<TGridItem> Is internal

franklupo avatar Jul 24 '24 10:07 franklupo

Ok but the InternalGridContext Is internal

Indeed ;-)

dvoituron avatar Jul 24 '24 11:07 dvoituron

IMO InternalGridContext could be deleted and move properties/methods to FluentDataGrid. FluentDataGrid is found in CascadingParameter, or change visibility InternalGridContext

franklupo avatar Jul 24 '24 11:07 franklupo

IMO InternalGridContext could be deleted and move properties/methods to FluentDataGrid. FluentDataGrid is found in CascadingParameter, or change visibility InternalGridContext

Nop. InternalGridContext exists to centralize some internal properties. The next major release could refactor this part to simplify the extensions.

dvoituron avatar Jul 24 '24 11:07 dvoituron

IMO InternalGridContext could be deleted and move properties/methods to FluentDataGrid. FluentDataGrid is found in CascadingParameter, or change visibility InternalGridContext

The InternalGridContext should be seen as the object holding the grid's internal state. We do not want to expose that.

vnbaaij avatar Jul 24 '24 12:07 vnbaaij

something is missing?

franklupo avatar Jul 25 '24 14:07 franklupo

Are there any problems applying this change?

franklupo avatar Jul 30 '24 11:07 franklupo

Hi Daniele, still not have time to take a proper look at this and won't be able for the coming weeks because of vacation period. There is no rush to get this in as it will require at least a minor release (i.e. 4.X)

vnbaaij avatar Jul 30 '24 12:07 vnbaaij

you're right, this change gives me the ability to create components outside of this library.

franklupo avatar Jul 30 '24 16:07 franklupo

Closing this as there has been no activity for a while.

vnbaaij avatar Nov 19 '24 08:11 vnbaaij