Daniel Vérité comments

Results 6 comments of


                                            Daniel Vérité

header file included twice in many places.

Thanks for noticing! I've made the includes a bit more consistent with commit 0161c1c C files can still include ICU files in common with icu_ext.h but I'm okay with that.

PostgreSQL 10 compatibility

Fixed by 91828aebb9b568e8b256d82a3b3dcc6a5d24ac42 Thanks for the report!

tempfile: command not found

What is your operating system? In Debian for instance tempfile is provided by the debian-utils package. Does it work if you replace tempfile with **mktemp** ?

tempfile: command not found

I'm afraid I don't have access to a MacOS machine to test, but it looks like mktemp does exist there, since people online are discussing how it differs from some...

tempfile: command not found

Committed the tempfile->mktemp substitution (4440fdaf2)

pgcopydb stopped with `[TARGET 0] SSL error: bad length` failure during WAL replay

This particular migration cannot be retried, it happened on production environment only. According to the console output, `pgcopydb` adds `keepalives=1&keepalives_idle=10&keepalives_interval=10&keepalives_count=60` to the URL of the connection. Independently of that, the...