Daniël van Eeden

proposal: encoding/json: Return the postion for validation failures.

1

### Proposal Details We use `json.Valid()` in https://github.com/pingcap/tidb to implement the [`JSON_VALID()`](https://docs.pingcap.com/tidb/dev/json-functions/) SQL function and would like to return the position on which the validation failed to the user. https://github.com/pingcap/tidb/blob/0875abde25467897e4e81ae6c18c5e8792ca28a9/pkg/expression/builtin_json.go#L1019...

Display GitHub Status

1

I would like to see a notification if https://www.githubstatus.com/ is reporting any issues. Same for other things like GitLab when configured.

Would be nice if this could should Jira notifications etc as well. However I don't know if Jira and/or Jira Cloud have a suitable API.

collector: Problematic use of process.ClockTicks

2

## Bug Report This is the same issue as https://github.com/pingcap/tidb-insight/issues/62 The code that has the problem: https://github.com/pingcap/diag/blob/514745da91ed13cd240a94eab52bfb97a6f97238/collector/sysinfo/process.go#L150 On FreeBSD this causes one direct and one indirect build failure. This was...

Flag the use of experimental features

1

## Feature Request The experimental features listed on https://docs.pingcap.com/tidb/stable/experimental-features and elsewhere are not recommended for production use. A `tiup diag check...` should be able to detect those and give proper...

Hard to read default color scheme

3

## Bug Report On CentOS 7 with the default terminal configuration the light-yellow on white as seen here is hard to read:  What version of Diag are you using...

Improved structured logging

2

## Feature Request Starting TiDB with the log format set to JSON allows for structured logging. ``` ./bin/tidb-server -config

parser: Support STRAIGHT_JOIN...USING

8

### What problem does this PR solve? Issue Number: close #54162 Problem Summary: ### What changed and how does it work? ### Check List Tests - [ ] Unit test...

types: Improve handling of errors in JSON

10

### What problem does this PR solve? Issue Number: ref #54207 Problem Summary: ### What changed and how does it work? Using `json.Valid()` is probably not the best solution here...

executor,infoschema: Add pad_attribute to collation info | tidb-test=pr/2354

10

### What problem does this PR solve? Issue Number: close #54250 Problem Summary: ### What changed and how does it work? ### Check List Tests - [x] Unit test -...