parser: Support STRAIGHT_JOIN...USING
What problem does this PR solve?
Issue Number: close #54162
Problem Summary:
What changed and how does it work?
Check List
Tests
- [ ] Unit test
- [x] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [x] Affects user behaviors
- [x] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [x] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Support for `SELECT ... STRAIGHT_JOIN ... USING ( ... )` was added
Hi @dveeden. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/ok-to-test
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 56.2233%. Comparing base (
6421f86) to head (b79c72d). Report is 10 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #54164 +/- ##
=================================================
- Coverage 72.8169% 56.2233% -16.5936%
=================================================
Files 1536 1659 +123
Lines 435926 610643 +174717
=================================================
+ Hits 317428 343324 +25896
- Misses 98865 243945 +145080
- Partials 19633 23374 +3741
| Flag | Coverage Δ | |
|---|---|---|
| integration | 37.4134% <ø> (?) |
|
| unit | 71.8242% <ø> (-0.0024%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.9656% <ø> (ø) |
|
| parser | ∅ <ø> (∅) |
|
| br | 52.6655% <ø> (+6.5944%) |
:arrow_up: |
[LGTM Timeline notifier]
Timeline:
ensuring that each of them provides their approval 😂
/assign bb7133 bornchanger d3hunter easonn7 tangenta
@lance6716: GitHub didn't allow me to assign the following users: easonn7.
Note that only pingcap members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
In response to this:
ensuring that each of them provides their approval 😂
/assign bb7133 bornchanger d3hunter easonn7 tangenta
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
ping @bb7133 @bornchanger @tangenta
I think we only need one more LGTM from sig-approver-parser i.e. @bb7133 / @BornChanger / @tangenta ?
Or do we also need additional approval from sig-critical-approvers-parser i.e. @yudongusa / @easonn7 too?
looks like approval from sig-critical-approvers-parser is required.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bb7133, D3Hunter, hawkingrei, kennytm, lance6716, yudongusa
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [D3Hunter,bb7133,hawkingrei,kennytm,lance6716]
- ~~pkg/parser/OWNERS~~ [D3Hunter,bb7133,yudongusa]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest