David

Results 93 comments of David

> Can you write it entirely in terms of the public API? You mean to instantiate the `MontyForm` values? Sure, I can try to do that. I think having known...

> Can you write it entirely in terms of the public API? Done.

> also compare results with `num-modular` @tarcieri I added a test using `num-modular`. It agrees with `crypto-bigint` v0.5.5.

@tarcieri @fjarri I think I have found another clue that might help us narrow down what is going wrong here. The problem seems to lie in the modulus, in the...

> That's 4-bits too small. Awesome sleuthing! I was thiiiiiis close, but you got there first! :)

> I'd appreciate it if you could rebase on that and see if it fixed your issues Yep, will do first thing in the morning.

> @dvdplm I haven't tested your specific vectors, but perhaps you could try that locally and see if it corrects the issue? Changing the `+ 1` to `+ 2` fixes...

> I'd appreciate it if you could rebase on that and see if it fixed your issues I have checked that #610 indeed fixes all test failures on this branch....

I for one do not understand what your question is. Can you elaborate?

I think you are talking about the `private` module's `Arg` trait, [here](https://github.com/nvzqz/divan/blob/5478a6008666bac5f2c15cb29814c34f8c68474a/src/private.rs#L40).