David

Results 93 comments of David

@fermuch @borisyankov Is there code cooking for this or would you welcome a PR? :) EDIT: first draft https://github.com/borisyankov/react-sparklines/pull/54

+1 on including this.

Which version of `ethabi-derive` did you fork? The latest 6.0 introduced quite a few changes. Any chance we can make it work for you guys? (/cc @debris) I know there's...

> It looks like a commit from the ethereum repo no longer exists in the tree. Do you have a fix for it? This is caused by a submodule not...

> **EDIT**: NVM, found fix [here](https://github.com/openethereum/openethereum/issues/11631). Now I can build with the master branch, still fails with the tag `v3.0.0-alpha.1` though Good, I forgot we had this come up recently....

Hmm, @denisgranha it looks like the CI is broken for this repo. Can you take a look please?

Sure, I don't see why not. If you want to feel free to open a PR, otherwise I'll do it.

I meant both really!

It'd probably be a good default to have a warmup. One thing users coming to divan from criterion will notice is that the output is noisier with divan.