Daniel Vandersluis comments

Results 102 comments of


                                            Daniel Vandersluis

trafficstars

Fix error in lib/httpclient/util.rb when frozen strings are enabled

Will this ever be merged?

saving a relation with using(:slave) causes additional where clauses to multiply

@platphorm did you try making that change in production? Are there any side effects you're aware of?

saving a relation with using(:slave) causes additional where clauses to multiply

@knodi makes sense!

Octopus.using block doesn't use the right shard for relations

Not that I know of.

false positive when using .order("FIELD(id, ...)")

FYI (and not that it's brakeman's fault), but @JasonBarnabe's solution triggers the Rails 6 deprecation warning from https://github.com/rails/rails/issues/32995. > DEPRECATION WARNING: Dangerous query method (method whose arguments are used as...

Ruby 3.0 support for broadcast with kwargs

If anyone else is encountering this, I fixed it by monkey patching `wisper` on my codebase: ```ruby module Wipser module Publisher # Wisper 2.0.1 does not properly support Ruby 3...

Support for heterogeneous records while serializing

I am in need of this feature as well, is there any way to help make it happen?

Revert "Temporarily disable rubocop 0.92 specs in CI"

@marcandre I guess we need a backport for v0.92 (or v0.93?) in order to make the tests there pass?

Documentation for named `_` and backreferences in node pattern

Thanks @marcandre! I’ll take a look if I get a chance. Happy holidays!!

Add `MasgnNode` class for `masgn` nodes

Sorry I missed this in my previous PR @marcandre 😅 🙌