Dusty Mabe

Results 645 comments of Dusty Mabe

> Now with a config knob, off by default. This definitely needs some careful review (whee shell script fragility) and testing (across all architectures really). +1 - i'll take a...

Let me know what you think of the optional comments. Otherwise everything LGTM. I can do a multi-arch build of COSA and run this through the staging bump-lockfile job with...

I think this PR is still useful. I wanted to get back to it and run it through some tests on multi-arch in the staging pipeline. This has also been...

going to close this out since we are moving away from using create_disk for our disk image creation.

Interesting idea. Why should we do this in COSA and not in say `virt-install`? If we do think COSA is the best place to do something like this: since we...

> > since we have the ability to inject kernel args, should we instead consider using the systemd.set_credential_binary= kernel arguments as the credential passing so it's not limited to just...

> > Why should we do this in COSA and not in say virt-install? > > They're different but related things. One can already pass credentials via SMBIOS by directly...

> Though we definitely also have bits that are of the more generic "convenience QEMU wrapper" I'm just wondering why we couldn't contribute these pieces into a library more dedicated...

This was done in https://github.com/coreos/coreos-assembler/pull/3643 osbuild is being run in our pipelines via a supermin VM.