Dustin Long
Dustin Long
Looks like the linter is unhappy, but this should be good to merge once that's fixed.
> I’m not sure that opening the log file, JSON-unmarshaling its whole content and marshalling it back and writing the whole file each time we refresh secrets is efficient. Do...
> Maybe an append only file that we truncate to certain size when the size reaches certain threshold might be a possible solution to avoid the parsing of old data...
Tests added: both of the audit-file limit getting reached when Refreshing secrets, and also for the new `filesystem.ReadFileWithSizeLimit` function.
Hi @L3n41c and @hush-hush, I have addressed your earlier review comments. Please when you get a chance, have a another look at this PR. Thanks in advance!
I have updated this PR to use a new facility "RotatingNDRecords". This will efficiently append to an ndjson (newline deliminated json) file, as described, but there's a few differences in...