[ASCII-1222] Remove the GetInstance singleton method from the secrets Component

[dustmop]

What does this PR do?

Now that the diagnose codepath has been cleaned up, we can remove the GetInstance() singleton method from the secret Component.

Motivation

It was a temporary hack, it's ready to be removed.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Both agent diagnose and agent secret should continue to work properly.

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 3d54464e-91af-4445-8b8d-33ab8a2c8974 Baseline: ff3eefad6f31c6721aac938cc25a8e6a5e5ea45a Comparison: ac0a9e0859d92f0f038a675937d0c8b240c171ed Total CPUs: 7

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Experiments with missing or malformed data

• basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.11	[-6.45, +6.67]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_tree	memory utilization	+1.09	[+1.00, +1.18]
➖	process_agent_standard_check_with_stats	memory utilization	+0.28	[+0.24, +0.31]
➖	file_to_blackhole	% cpu utilization	+0.11	[-6.45, +6.67]
➖	process_agent_standard_check	memory utilization	+0.10	[+0.06, +0.13]
➖	process_agent_real_time_mode	memory utilization	+0.09	[+0.05, +0.12]
➖	trace_agent_json	ingress throughput	+0.01	[-0.03, +0.06]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	trace_agent_msgpack	ingress throughput	-0.01	[-0.02, +0.00]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.30	[-0.38, -0.22]
➖	idle	memory utilization	-0.53	[-0.56, -0.50]
➖	otel_to_otel_logs	ingress throughput	-0.91	[-1.53, -0.30]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.24	[-2.65, +0.16]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[dustmop]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Added to the queue.

There are 9 builds ahead of this PR! (estimated merge in less than 2h)

Use /merge -c to cancel this operation!