plonk

plonk copied to clipboard

Refactor Composer into trait

1

A composer is a set of functionalities that can be extended into different implementators, such as debuggers or even PLONKup. This commit introduces the composer as trait, and targets to...

vlopes11

### What's wrong Fix #541 ### How we are fixing this - [x] create a test to make sure it fails when one of the `qfixed` and `qvar` are switched...

ChihChengLiang

`fn coset_fft_in_place(&self, coeffs: &mut Vec) { Self::distribute_powers(coeffs, GENERATOR); self.fft_in_place(coeffs); } pub const GENERATOR: Scalar = Scalar([7, 0, 0, 0]); ` for the 'GENERATOR', why we use this value in Montgomery...

simplelins

**Describe what you want implemented** Eliminate `expect` in `append_output_witness` by propagating an error if `q_o` is `0`. **Describe "Why" this is needed** A malicious user can crash a plonk server...

moCello

**Describe the bug** Code coverage fails because it takes the wrong commit for master, see: https://github.com/dusk-network/plonk/pull/668 The current master at that point in time was: https://github.com/dusk-network/plonk/commit/d8ef7908db1f4995883e5e64db8d68e9cc343483 (just pushed) But the...

ZER0

We usually store multiple `Evaluations` inside the same structure (`ProverKey` is an example of that). It's really sub-optimal to store the same `EvaluationDomain` across all of the `Evaluations` of the...

CPerezz

**Describe what you want implemented** The polynomial `z_2` in round 3 needs a permutation challenge `theta` to be computed. This seems to not be implemented yet. **Describe "Why" this is...

moCello

Add documentation of the concepts behind PLONK

1

moCello

This name is duplicated with the base Proof. This is often misleading and we should consider a new name for this struct

vlopes11

Currently there is a lot of code repetition and complexity under `proof_system/widget` modules, it should be definitely possible to reduce and improve the ergonomics of the code.

ZER0