Đurica Yuri Nikolić comments

Results 16 comments of


                                            Đurica Yuri Nikolić

feat: add save to directory option for mimirtool rules get

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase `main` and eventually move the CHANGELOG entry added / updated in this PR to the...

Store-gateway: allow mark/delete no-compaction from admin UI

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase `main` and eventually move the CHANGELOG entry added / updated in this PR to the...

Integration test: return a 422 status code when store-gateway and quierier hit the max-fetched-series-per-query limit

> The *pb packages should contain only protobufs. @pracucci I have fixed that and moved the 2 sources to the storegateway package instead. For the rest, let's discuss it next...

Improving globalerror package

> generally I didn't see any blockers with the PR. But I'm wondering if we really need 2 different ways to wrap GRPC errors - `ToGRPCStatusError` and `WrapErrorWithGRPCStatus`. Wouldn't it...

Improving globalerror package

> > > generally I didn't see any blockers with the PR. But I'm wondering if we really need 2 different ways to wrap GRPC errors - `ToGRPCStatusError` and `WrapErrorWithGRPCStatus`....

If ring instances have conflicting tokens, rings can compute different instance ownership.

Hi @pstibrany, The first remark I have here is: does it make sense that instances have conflicting tokens? In the current design I guess it is not the case. Otherwise,...