mimir icon indicating copy to clipboard operation
mimir copied to clipboard

Store-gateway: allow mark/delete no-compaction from admin UI

Open ying-jeanne opened this issue 1 year ago • 3 comments

What this PR does

Compactor is sometimes unable to compact blocks because they are too big, until we increases compactor memory requested manually, we often mark for no compact the specific block. (there are also other cases we mark for no compact blocks when data corrupted) This PR simplifies this operation.

Allow admin to mark/delete no-compact from admin UI, followup of: https://github.com/grafana/mimir/pull/6917 and https://github.com/grafana/mimir/pull/6848. Note metric cortex_compactor_blocks_marked_for_no_compaction_total was not passed to block.go intentionally. This metric is excluded because normally we rely on it for monitoring the number of compaction that have failed, and in this context, the marking or deletion of "no-compact" status is a intentional and manual action.

The local test output

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • [x] Tests updated.
  • [x] Documentation added.
  • [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [x] about-versioning.md updated with experimental features.

ying-jeanne avatar Dec 13 '23 17:12 ying-jeanne

the block_ulids is trasmit as json object, tested with frontend and backend, since it is URL-safe, no encoding needed.

ying-jeanne avatar Dec 26 '23 14:12 ying-jeanne

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

duricanikolic avatar Mar 12 '24 09:03 duricanikolic