Louis Dureuil

Results 261 comments of Louis Dureuil

Thanks for opening this, @loiclec! I don't really have thoughts that are specific to the subject at hand, but more general ones about the kind of topic this is: every...

> So if someone already has implemented a middleware before, I'd like his insights about the time it would take. (@Kerollmops or @dureuill?) I already implemented middleware, but in Django...

Hello :wave:, so I took some time to make a small survey of rate limiting in other projects (open source, competitors, SaaS, ...), so here's what I got: 1. On-premise...

Opened an experimental PR to add a rate limiter based on Actix-governor: https://github.com/meilisearch/meilisearch/pull/3283

> I think this will not occur anymore That's great! I think we can do either of: 1. keep the panic behavior with some documentation on the precondition of the...

> I think the DB should be made optional such as if an index has no entry in the cache, then it is fetched eagerly and added to the cache....

Pushed an update with the following changes: - Rebase on main - Switch the DB to UUID -> Stats instead of str -> Stats - Fallback to eager computation of...

@irevoire doesn't look like I can request your review (which is a bit silly since I changed your PR, but...). Also requesting @Kerollmops ' review

Updated: - Restore contribution of the index sizes to the db size - the index size now contributes to the db size even if the index is not authorized -...

This PR also fixes #3578