Louis Dureuil
Louis Dureuil
Fresh weekly update :-) - Queries and results are now wrapped in a JSON object. This is, notably, for future-proofing and consistency with the rest of the API. - `index_uid`...
Thank you @irevoire ❤️ We need to rebase to accommodate for the wildcards in tenant tokens though. We'll take a look with @Kerollmops this very afternoon 😃
Renamed the new route from `/search` to `/multi-search`. The PR description is up-to-date
Changed event name in analytics
Pushed an update to handle the case where an error (eg IoError) would leave the hashmap in an inconsistent state.
I feel that with the tests I did, and the that that milli is now in main, this PR is now ready for review.
> Do you think there is a way to test this behaviour, though? It should really be in this PR, but #3331 adds automatic tests of index resizing.
Changed error handling: - Indicate the index of the query causing the failure inside of the `queries` array with format: ``` Inside `.queries[{i}]`: {original_msg} ``` - Return a 400 HTTP...
Thanks @irevoire ! I'm adding @ManyTheFish to the list of reviewers like we discussed in the team
> Just a "simple" rebase and we are good to merge Rebase OK, I also squashed some of the more redundant commits! Just a little approval and we're good to...