Duncan Sutherland
Duncan Sutherland
> @dcpedit Please can PR Checklist guidance be followed regarding PCBs with multiple physical layouts This point still stands 😊
> Just to clarify, is the ask here to change the layout macro name to `LAYOUT`? In particular, taken from PR Checklist: - If the keyboard has multiple electrical/switch layouts:...
Presuming image in [Instagram post](https://www.instagram.com/fe.works/p/DE51eMGPIpH/?img_index=1) is accurate, then this PCB supports community layouts: - tkl_ansi - tkl_ansi_split_bs_rshift - tkl_iso - tkl_iso_split_bs_rshift - tkl_ansi_tsangan - tkl_ansi_tsangan_split_bs_rshift - tkl_iso_tsangan - tkl_iso_tsangan_split_bs_rshift
> If you could consolidate shared configuration between the `hotswap` and `hotswap_rgb` revisions into a top-level `info.json` file, and hardware-specific configuration in the individual `keyboard.json` files. To assist, file structure...
Please label as awaiting review
Please label as awaiting review
please label as awaiting review
please re-open
Hi @CMMS-Freather, The image in `readme.md` shows a multi-layout PCB which is contradicted by `keyboard.json` being an ANSI layout. If it is true that this PCB is multi-layout and a...
> the image shows correct layout. I think I didnt change to layout_all to show the actual possible layouts. What is the best and easiest way to comply the PR...