adding fave 10xs pcb firmware

[CMMS-Freather]

adding fave 10xs pcb firmware

Description

adding fave 10xs pcb firmware

Types of Changes

• [ ] Core
• [ ] Bugfix
• [ ] New feature
• [ ] Enhancement/optimization
• [x] Keyboard (addition or update)
• [ ] Keymap/layout (addition or update)
• [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

• [x] My code follows the code style of this project: C, Python
• [x] I have read the PR Checklist document and have made the appropriate changes.
• [x] My change requires a change to the documentation.
• [x] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [x] I have added tests to cover my changes.
• [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[dunk2k]

Hi @CMMS-Freather,

The image in readme.md shows a multi-layout PCB which is contradicted by keyboard.json being an ANSI layout.

If it is true that this PCB is multi-layout and a user flashes this ANSI specific firmware when user has built keyboard for ISO, then the NUBS key (assuming matrix co-ordinate 4, 1) would not function.

Could I ask, as non-collaborater, that either the image of the PCB is changed or information in layouts is changed to adhere to PR Checklist regarding multi-layout PCBs/keyboards?

[CMMS-Freather]

Hi @CMMS-Freather,

The image in readme.md shows a multi-layout PCB which is contradicted by keyboard.json being an ANSI layout.

If it is true that this PCB is multi-layout and a user flashes this ANSI specific firmware when user has built keyboard for ISO, then the NUBS key (assuming matrix co-ordinate 4, 1) would not function.

Could I ask, as non-collaborater, that either the image of the PCB is changed or information in layouts is changed to adhere to PR Checklist regarding multi-layout PCBs/keyboards?

the image shows correct layout. I think I didnt change to layout_all to show the actual possible layouts. What is the best and easiest way to comply the PR checklist? Should I just change to layout_all?

[dunk2k]

the image shows correct layout. I think I didnt change to layout_all to show the actual possible layouts. What is the best and easiest way to comply the PR checklist? Should I just change to layout_all?

Changing to or adding LAYOUT_all by principle would require all used keys/matrix co-ordinates to be present in LAYOUT_all layout; which isn't the matter with the current fullsize_ansi_extended layout 🙈

[CMMS-Freather]

the image shows correct layout. I think I didnt change to layout_all to show the actual possible layouts. What is the best and easiest way to comply the PR checklist? Should I just change to layout_all?

Changing to or adding LAYOUT_all by principle would require all used keys/matrix co-ordinates to be present in LAYOUT_all layout; which isn't the matter with the current fullsize_ansi_extended layout 🙈

would you mind if I ask what is the best option for me to modify the code to fit the pr requirements?

[dunk2k]

would you mind if I ask what is the best option for me to modify the code to fit the pr requirements?

Based on PR checklist:

1. Keep the layout fullsize_extended_ansi in layouts
2. Add another layout to layouts named LAYOUT_all "which specifies all possible layout positions in the electrical matrix".
   Looking at image in readme.md, LAYOUT_all layout would show split backspace, split left shift, split right shift, split/segmented spacebar, grided numpad (i.e no 2u keys), and ISO NUHS key (i.e. left of ISO Enter) if it is not same matrix co-ordinate as ANSI BSLS.

[CMMS-Freather]

would you mind if I ask what is the best option for me to modify the code to fit the pr requirements?

Based on PR checklist:

1. Keep the layout fullsize_extended_ansi in layouts
2. Add another layout to layouts named LAYOUT_all "which specifies all possible layout positions in the electrical matrix". Looking at image in readme.md, LAYOUT_all layout would show split backspace, split left shift, split right shift, split/segmented spacebar, grided numpad (i.e no 2u keys), and ISO NUHS key (i.e. left of ISO Enter) if it is not same matrix co-ordinate as ANSI BSLS.

updated based on suggestion. ansi bsls and enter is the same as iso nuhs and enter in electrical matrix. thus not displayed in keyboard.json

[dunk2k]

updated based on suggestion. ansi bsls and enter is the same as iso nuhs and enter in electrical matrix. thus not displayed in keyboard.json

Excellent work 🙂 just the layout to change in default keymap then it's all good from PR Checklist perspective (in my view) 😉

[github-actions[bot]]

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.