Christian Folini

Results 509 comments of Christian Folini

But that means this PL2 FP will persist? Or do you want the PR for #3498 to do a new rule and remove this FP at the same time?

That's priced in, yes. Thanks for the PR.

Removing the stale issue. This is something that warrants a fix. Feel free to add the v4 lable anyone.

Thank you for investigating. I am not nearly enough in the code and in this feature to know or remember.

We sorted this out at the CRS meeting and opted to implement the above. https://github.com/coreruleset/coreruleset/issues/3466#issuecomment-1881762255 @theseion will provide his perf numbers (no perf loss expected).

We're talking about `log_contains`, don't we? Consolidation for the win!

This is really strange.