dukebody

Results 85 comments of dukebody

Hi @chanansh ! I integrated a modified version of your `FeatureUnion`-based pipeline into the current version of DataFrameMapper in https://github.com/paulgb/sklearn-pandas/tree/feature_union_pipe. Let me know what you think.

Good idea! I believe we can generate feature names from the selected columns, like it's done in the PR now, and allow the user to provide a custom name as...

Don't worry, I'm already working on this myself. Will upload updated code this evening.

Hi @havardl . We worked on this like one year ago, but honestly I don't think it adds so much value in terms of features compared to the amount of...

I believe this should be possible if the transformer you use implements some interface to get the name of the resulting features. See https://github.com/scikit-learn-contrib/sklearn-pandas/blob/master/sklearn_pandas/dataframe_mapper.py#L40. Perhaps you can extend `SelectKBest` to...

Sorry for the big delay. Does this issue cause you trouble somewhere else? If you know how to fix this, can you submit a PR with the fix? Thanks!

I believe this functionality, if implemented, would better be a component outside of the `DataFrameMapper`, to avoid overloading this class with too complex custom behaviour - it's already quite complex,...

First of all, sorry for not getting back to you sooner. What you ask for is not possible right now, but would be a _very_ interesting addition. I will review...

While changing the whole DataFrameMapper to use FeatureUnion allows to set transformers internal parameters and has the benefit of being able to run in parallel, I wonder if we cannot...

See https://github.com/paulgb/sklearn-pandas/tree/feature_union_pipe