Damian Poddebniak

Results 9 comments of Damian Poddebniak

- [ ] Add validation for PSKs https://github.com/mlswg/mls-protocol/pull/691/files#diff-7c369b85b26a746a7e70cd2884037896defe03b3098bec976f79c994d22a604aR3430-R3431 - blocked on #877 - [ ] Remove `PreSharedKeys` https://github.com/mlswg/mls-protocol/pull/691/files#diff-7c369b85b26a746a7e70cd2884037896defe03b3098bec976f79c994d22a604aR4032 - blocked on #751

Changes ("L..." at end of URL is line number): ### Renames * `MLSMessageAuth` --> `MLSContentAuthData` * `MLSMessageContent` --> `MLSContent` * `MLSMessageContentAuth` --> `MLSAuthenticatedContent` * `MLSMessageContentTBS` --> `MLSContentTBS` * `MLSMessageContentTBM` -->...

### Changes * Add `version` to `MLSMessage` https://github.com/mlswg/mls-protocol/pull/600/files#diff-7c369b85b26a746a7e70cd2884037896defe03b3098bec976f79c994d22a604aR1380 ```diff struct { + ProtocolVersion version = mls10; WireFormat wire_format; select (MLSMessage.wire_format) { case mls_plaintext: MLSPlaintext plaintext; case mls_ciphertext: MLSCiphertext ciphertext; case...

Maybe this information is helpful for someone. There is an AFL adaption to Rust programs available, see https://github.com/frewsxcv/afl.rs.

Current state: duesee/spec_issue_979 I'll try the following: In order to minimize the changes that have to be done manually and to avoid confusing types in certain places, I'll first only...

Nice, spot fuzzing is cool :-) I hoped a bit that the `unimplemented!()` part of the code will not be reachable and I can get away with it until I...

I'm working on another branch to fix #979. These are the changes so far that should be easy to review and low-risc to take. Making slow progress :-)

@raphaelrobert I could rebase and fixup the commits before you do the review. Depends a bit on your review style (commit-by-commit) or "Files changed", I guess.

> I also saw that you force-pushed again. It potentially causes much more work for reviewers and we might just not review PRs with forced pushes going forward. Force pushing...