Duckki Oe

ERC20 contract loses tokens sent to the contract's own address

5

**🧐 Motivation** Many people lose their ERC20 tokens by mistakenly sending their tokens back to the token contract address (presumably to redeem their tokens). However, there is no way to...

AST parser fix: find the correct jump destinations for `continue` statements

1

This PR fixes https://github.com/crytic/slither/issues/435. ### Issue `_fix_continue_node` doesn't always find the correct jump destination for `continue` statement. ### Proposed Solution In this PR, I propose the record the continue destination...

Remove sons of `revert` node

1

This PR fixes https://github.com/crytic/slither/issues/1708. * The function parser removes all outgoing edges from expression nodes that calls one of the`revert` functions. * AST tests confirm the removal of CFG edges...

### Describe the issue: The flattened output generated by slither-flat may declare contracts/interfaces out of order, which can't be compiled. ### Code example to reproduce the issue: BSCscan address: https://bscscan.com/address/0x42d1aab8cbb202bc0b74c75da0fd999eec4a5c07#code...

Feature request: `--config-settings` options with `pipenv install`

7

### Is your feature request related to a problem? Please describe. `pip install` accepts `--config-settings X=Y` options, but it seems not possible to pass it using `pipenv install`. ### Describe...

Interface conditions fragments may not be used across spreads, discouraging reusability

2

(This idea was inspired by https://github.com/apollographql/federation/issues/2952 .) ### Motivating example Schema: ```graphql type A { f(arg:String!): String! } interface I { id: ID! f(arg:String!): String! } type B implements I...

ValueError from `filename_lookup` resolving an import path (truffle platform)

3

The `CryticCompile.filename_looup` crashes when resolving import directives. Reproducer: [test-filename-lookup-error.zip](https://github.com/crytic/crytic-compile/files/8182615/test-filename-lookup-error.zip) Contents: ``` . └── subdir ├── contracts │   ├── Context.sol │   └── Test.sol └── truffle-config.js ``` Since `filename_looup` is used only...

[Docs]: Implicitly declared local variables (in `def` functions) may not be function-scoped

2

### Bug description Implicitly declared local variables are supposed to have the function-level scope (as stated in [the doc](https://docs.modular.com/mojo/manual/variables.html)). But, it appears to be restricted to the scope they were...

FED-32: Port `tryOptimizeSubselectionWithFragments`

2

Implemented `try_optimize_with_fragments` function. - Added a new file `optimize.rs` under `query_plan`. - Refactored some SelectionSet methods and moved them to SelectionMap for reuse. --- **Checklist** Complete the checklist (and note...

Fixed a subtle bug in add_at_path method

2

- New sub-selections used to use the root type as its type_position, not the current element's base type. - added `OpPathElement::sub_selection_type_position` --- **Checklist** Complete the checklist (and note appropriate exceptions)...