Dubois Emmanuel

Results 15 comments of Dubois Emmanuel

remarks: - how can we get a unique dynamic automatic list of all coreg available ? (equivalent to https://github.com/CNES/demcompare/blob/master/demcompare/coregistration/coregistration.py#L88) - is there a coreg "factory" class or equivalent ? to...

Ok for the need of scalar metrics, the issue is clear. Will it be possible to choose a metric from a calling pipeline with a configuration file as demcompare ?...

on the general linting, i agree to put something at the beginning to benefit from the quality wrappers for all code to be done afterwards. I think it is a...

Ok see internally if it is misconfiguration of ruff and if not enough mature (it's weird nonetheless) I think we keep isort, black, flake8, pylint, mypy as a baseline.

Some remarks: - "reference_dem": str, "dem_to_be_aligne": str . more explicit than demcompare (good!). so reference_dem ok for me. maybe test_dem (to be aligne long and not so clear for user)....

Ok for the principle to begin on xdem tests to "feel" the code and be able to understand better xdem for integrating demcompare-like cli. Be aware to think how we...

Ok for me, it is the demcompare simple cli interface (name_of_program_exe configfileinjson.json). Some quick remarks: - I would prefer a dedicated xdem_cli.py explicitely file and so xdem = xdem.xdem_cli:main in...

Hello, - for the parser, i agree that click is a good tool but only if we plan to have the parameters in the command line directly. For our demcompare...

My feeling is that if we keep several way of configuration, it would be complex to deal. The conversion add complexity and is never perfect because of the intrinsic capacity...

see remarks in #554 on pipeline code organization and a factory to add every coregistration method and limit code duplication.