Duane Griffin comments

Results 6 comments of


                                            Duane Griffin

Add support for Metaname DNS API

Sorry for the delayed response: took a while to find time to test properly.

Add support for Metaname DNS API

As far as I know this addresses your points and is working properly. The CI failure previously was a Travis issue rather than an issue with the code.

asyncio socket write a multi-dimensional memoryview could truncate data

This reproduces on `HEAD`. Note partial writes of `memoryview`s of non-byte arrays are also affected!

asyncio socket write a multi-dimensional memoryview could truncate data

In case it is useful to anyone, a reproducer using `array.array` (doesn't require numpy): ``` import array import asyncio import hashlib import socket import tempfile done = asyncio.Event() socket_path =...

asyncio socket write a multi-dimensional memoryview could truncate data

> The code already checks for "'data argument must be a bytes-like object" AIUI a `memoryview` is a byte-like object, but its _elements_ are not necessarily bytes, and passing a...

asyncio socket write a multi-dimensional memoryview could truncate data

> I think fixing the docs is the appropriate thing to do for now, I'm -1 for any code changes here. Very well. I strongly disagree, but such is life....