Danny Turner comments

Repositories
Issues
Comments

Results 5 comments of


                                            Danny Turner

Scopes on associations

@hubert Anything I can do to help get this merged? Also, thank you for stepping up to help maintain Her.

Ignore belongs_to relations when parsing params

@aauthor :+1: @balvig Take a look at https://github.com/remiprev/her/pull/261 I think that will explain the problem.

Include has_one attributes correctly when calling to_params

@filib I suspect it has to do with https://github.com/remiprev/her/issues/324 . Once things get back on track I'll be happy to merge master back into this PR

Include has_one attributes correctly when calling to_params

@hubert Thanks for looking into this again. (1) I've changed the code to be more defensive. (2) Conflicts are resolved (3) Version bump is removed

Include has_one attributes correctly when calling to_params

I'm not a big fan or rebasing. Can you explain why you think its preferable to the master merge here?