Don Turner

Results 225 comments of Don Turner

What's the status of this PR please? Should we merge it and run our API30 instrumented tests using GMD + ATD [instead of reactivecircus](https://github.com/android/nowinandroid/blob/main/.github/workflows/Build.yaml#L93)?

There's a request from the GMD team to reintroduce this into the project. @thagikura would you be able to update to AGP 7.3.0 and merge this please? We can then...

Thanks for submitting this. To remove the extra commits, please do: `git rebase main` then force push `git push -f` onto your branch.

This is looking great, thanks. A few comments/suggestions... Please add UI tests to `NavigationTest` to verify that: - When tapping on a topic chip the user is taken to the...

Yes, fine to just add tests in this PR.

Sorry for the delay in responding here. After some internal discussions we've decided that the topic chip interaction shouldn't have a drop down menu for following/unfollowing. This is because the...

This looks great, but we're going to need to review the enterprise license for using this tool before approving this PR.

@diverdan92 Please could you fix the build issue (try adding the `:core:domain` repository), and the merge conflicts.