Dmitry Tantsur
Dmitry Tantsur
> Has anyone contacted Facebook yet? Because this does not align well with their own spirit of open source while suing undergrads/graduates. There is no such thing. It's just become...
Actually after thinking a bit more, I'd suggest renaming items in the enum (especially since you already had name conflict with Dict) like: ``` pub enum Bencode { EmptyValue, NumberValue(i64),...
Key looks good. Btw with today's approved rfc about enum namespacing you'll soon be able to get rid of Value ending in enum elements.
Hmm, we're seeing a significant regression in user messages, presumably because of this. Granted, it's hard to provide good error messages for something like ```python {'anyOf': [{'additionalProperties': False, 'properties': {'hostname':...
Another pretty unfortunately example from our API: ```python STANDARD_TRAITS = # ... some list CUSTOM_TRAIT_PATTERN = "^CUSTOM_[A-Z0-9_]+$" TRAITS_SCHEMA = {'anyOf': [ {'type': 'string', 'minLength': 1, 'maxLength': 255, 'pattern': CUSTOM_TRAIT_PATTERN}, {'type':...
Actually, opened a new bug instead of poking the already closed one: https://github.com/python-jsonschema/jsonschema/issues/991
> func.retry.sleep = mock.Mock() Unfortunately, you don't always have an access to the function in a unit test. I'd rather go with the proposal in #228.
Looks good if passes.