Don Syme

* I'm concerned about naming being confusing when colliding with existing functions, esp. `List.choices` v. `List.choose`. Perhaps * List.randomShuffle * List.randomShuffleWith * List.randomChoices * List.randomChoicesWith * List.randomSample * List.randomSampleWith It...

p.s. great to see progress on this

@Lanayx Sorry for the churn, but I don't think the module is the right way to go - could you revert to the prefix please? Thanks!

Merged! Thank you everyone for your hard work on this

Ultimately the team looking after the `dotnet/fsharp` repo do really have a right of veto on this. @KevinRansom I'd request that we get those concerns raised much, much earlier in...

Interesting thanks! BTW what's the cost of the locking involved in Random.Shared? Just out of curiosity really. I think from this I still approve the RFC, and my preference would...

> Do you mean [System.Random.Shared in the BCL](https://github.com/dotnet/runtime/blob/fb1fe7f3481fc88fa477268c18d60d824b83c314/src/libraries/System.Private.CoreLib/src/System/Random.cs#L54-L55)? If so, [it uses an implementation with a ThreadStatic private field for thread-safety](https://github.com/dotnet/runtime/blob/fb1fe7f3481fc88fa477268c18d60d824b83c314/src/libraries/System.Private.CoreLib/src/System/Random.cs#L359-L468) instead of explicit locking (that technique is also what...

@KevinRansom @vzarytovskii @abelbraaksma Comments on this please?

I would say we should split like in the first example. > Related, patterns do seem to have some funky offset rules from time to time. This seems like a...

From a style guide perspective, the above proposal seems fine.