Don Syme comments

Results 1217 comments of


                                            Don Syme

[style-guide] Presence of shebangs in scripts

This can be captured, yes, we should treat this as an FCS/ fantomas bug

Question about operators starting with `?`

The docs and spec should be updated, thanks

[style-guide] Better control of pattern match handlers and line breaks.

Cool, I batch these up :)

[style-guide] Better control of pattern match handlers and line breaks.

I'm running through the style guide questions in this repo at last. I agree with @isaacabraham that at option (4) listed above should be an option. I personally would be...

[style-guide] Better control of pattern match handlers and line breaks.

> The main issue with this persistence mode is that you need to potentially format each clause to see if it is multiline or not. This feels expensive to check,...

[style-guide] Formatting of argument lists

Decision on (4) is here: https://github.com/fsharp/fslang-design/issues/663

[style-guide] Formatting of argument lists

On (2) I agree, ideally we should never break namespaces, I think under any circumstances. However it will be difficult to implement because namespaces are not known to fantomas. I...

[style-guide] Formatting of argument lists

On (3) I'm torn, it's not a simple choice. I'm aware it is a realy problem in practice. There is also a major risk of being inconsistent with functions and...

[style-guide] Formatting of argument lists

@auduchinok I've added tupled and mixed cases to the above. What do you think for static members? And is there any reason that case would be different?

[style-guide] Formatting of argument lists

@auduchinok basically it seems it is only curried `let` that's a problem for single-indentation, because of the unfortuanate exact alignment between function name and curried arguments. But of course it's...