Don Syme

Results 1217 comments of Don Syme

I'm fairly inconsistent about this and jazz format a lot. A random selection of examples from dotnet/fsharp ```fsharp | ForEachThen (isFromSource, firstSourcePat, firstSource, JoinOrGroupJoinOrZipClause(nm, secondSourcePat, secondSource, keySelectorsOpt, pat3opt, mOpCore), innerComp)...

Perhaps 1. Format on one line if possible 2. Format on two lines if possible with `when` at start of second line 4-spaces in 3. Otherwise format on multiple lines...

> Something just comes to mind where the `->` needed to be on the next line to remain valid. I'm not aware of any cases needing this. I checked this...

Yes, you're right, well-spotted :)

Agreed this can be a known limitation

For me the problem is that this leads to significant visual confusion between the expression on the right of the `->` and the when expression: ```fsharp | ILMemberAccess.FamilyOrAssembly | ILMemberAccess.Assembly...

I looked at this again and am still inclined to follow the rules here: https://github.com/fsharp/fslang-design/issues/662#issuecomment-1129906464 There are real readability issues with the `when` at the end. In order to understand...

I would have thought the default result should at least align with the deafult formatting of the expression that corresponds to the patternm e.g. ```fsharp SomeVeryLongMatchCase( 1234567890, 1234567890, 1234567890, 1234567890,...

> The broader question would be: "What F# versions should the style guide support?". We should support the latest major version, and perhaps adding notes to the style guide for...