Don Syme
Don Syme
I updated the prototype for set diff'ing to use an imperative 'while' loop - I haven't tested it yet, nor performance-tested it
I suspect for maximum performance (and lowest allocation) the diffing should probably use this signature: ``` val symmetricDiffWith: set1:Set -> consumer: ('T -> bool -> unit) -> unit ``` rather...
> val symmetricDiffFold: set1:Set -> consumer: ('acc -> Choice2 -> 'acc ) -> seed: 'acc -> 'acc I guess this is why returning `seq` is sensible. I'd like to check...
BTW one annoying problem with `Choice` is that it is an allocation per element of the map....
> Isn't it the case with tuples too ? Yes, though we could make it a struct tuple. FSharp.Core doesn't (yet) contain StructChoice unfortunately
Hi @njlr! Yes, a PR with good testing would be accepted You might need to update the engineering in this repository a bit - I haven't checked lately but I...
Oh also make sure you bump the version numbers too (via CHANGELOG)
From compiler office hours: @dsyme says: > 1. A stack trace would be the first thing, to find which phase. > 2. Minimizing the sample more if it can be...
> I discovered that the compiler does not infer obj as default type in inline exprs if full annotations are given in partial function application. Is this in the body...
I referenced this in #6805 to make sure we pin down known status for this in that branch