Dave Syer

Results 522 comments of Dave Syer

I put that change on a branch because I'm not sure it's finished (there's no test for instance), but I think it fixes this issue.

The change is linked to above my last comment.

@lejeunen would you mind opening a new issue in spring-cloud-config for this, unless you feel strongly that it belongs in commons (I didn't see the connection)?

Micrometer can only tell you about metrics for the local process, right? I also think prometheus is a good idea, but overkill for the simplest use cases. I definitely wouldn’t...

I think I would be happy with local metrics to start with (we have statistics about requests we sent to each service instance from the current JVM at least). It...

We can definitely autowire the handler. Actually we already do. So what did you try that didn't work? What is your function method signature? How do you ask for raw...

Maybe. I thought of it as an implementation detail though (users shouldn’t need to be aware). Wouldn’t it make more sense to inject the `LocalWired` into your function?

I guess you need to call `initialize()` before the handler then? It would be easier with a concrete sample.

Yeah, maybe. I think I'm going to stop using the `AppDeployer` until it supports this fetaure anyway.

I think a variant of option 2 will work (cf http://javadoc.io/doc/org.springframework.cloud/spring-cloud-commons-parent/1.1.4.RELEASE). The parent project can aggregate javadocs and publish them as a single jar. The only tricky thing is then...