Dave Syer comments

Results 522 comments of


                                            Dave Syer

Removal of the showResourcesVetList method dead code

The UI is clearly meant to show HTML. The `/vets` endpoint still works (and gives you JSON or XML depending on what you ask it for). I think that was...

Removal of the showResourcesVetList method dead code

Maybe we should put the links back? Or at least add some instructions about how to get the XML and JSON?

Replaced != with !Objects.equals()

I don't think this change is necessary, so I'll pass, but please send more if you find other things that inspire you.

Improve Error Information when CommonsExecWebServer does not start

+1 to this. If you already have a server running on the port you need instead of saying "port already in use" the error is "The server failed to start"...

Generated Models for Java have Invalid code

Ping @brendandburns back on this. There seems to be no way to use the generator right now until everything moves up a step and this JSON thing gets fixed.

Generated Models for Java have Invalid code

I was able to get something working just for my CRDs from master (84f2bc9e34129f92606a00fccb8c5c62204012b9) by discarding the `io.kubernetes.client` generated code and using the published API in version 20.0.0 from https://github.com/kubernetes-client/java....