Dave Syer

Results 522 comments of Dave Syer

Sure, but my point was that it isn't even really a config client feature. Just a resource type / resolver (which is a core Spring Framework feature, but the security...

It’s already generically provided by the Spring `Resource` abstraction.

"Pulling a resource" is normally something that happens in the bean lifecycle. That might happen after a refresh event, for instance. Whether that makes sense in the context of your...

I don't care about the name really. How about `JBANG_LAUNCHER`? I get that it's not guaranteed to work if the launcher isn't used, but at least it provides a way...

If #1811 is merged we could implement a JBang launcher API by referring to `System.getenv("JBANG_LAUNCH_CMD")`. That might be cleaner. Would be good to have access to the original command line,...

Might be good to have a test? There are "fat jars" already in use in existing tests (e.g. `TestRun.testHelloWorldGAVWithAMainViaAlias`) that could be modified? I just tried that test and it...

Using `@fatjar` works now with 0.117.0 (it skips the dependencies), so this issue is probably redundant. I.e. ```bash $ jbang io.quarkus:quarkus-cli:1.8.1.Final@fatjar ```

+1. Might be useful to have it add `target/classes` automatically as well?

Parameterizing the magic would be the most flexible, but maybe it would help to use some conventions to choose the defaults? Eg a repo with “snapshot” in the name would...