Daniel Swarbrick
Daniel Swarbrick
Sounds reasonable to me. Do you want to submit a pull request?
> Can anyone confirm what BBU status 32 means? The BBU status indicates the type of BBU. A value of 0 is CacheVault (i.e. supercap), and a value of 32...
You're probably right. I remember trying to make sense of the bbu status value with @mulbc last year, and due to our limited sample size, the best guess we could...
FWIW, there is some quite useful code to use as a guide in https://github.com/libstorage/libstoragemgmt/blob/master/plugin/megaraid/megaraid.py. Unfortunately I did not yet find any definitive information about the battery status value bitmap.
I wonder, is it worth maintaining both a shell script and a Python version of this collector? If so, why? IMHO, the Python version would be considerably easier to enhance,...
This is yet another case where using the JSON output of smartctl would be more robust, which uses a key of `serial_number`.
> Also, parsing JSON in a shell script is tricky without some auxiliary package like `jq` I was thinking mainly about the Python collector, i.e. refactor the Python variant of...
Ok, that race was unexpected. `http.Client` is supposed to be safe for concurrent use by multiple goroutines, but apparently it sometimes isn't. If I use a fresh client in `XMLClient.Get`...
I'm pretty sure it's actually a bug with the httptest.Server mock, because adjusting the timeout specified to `NewExporter` allows the test to succeed. ```go func (b bindExporterTest) run(t *testing.T) {...
@SuperQ After letting this stagnate such a long time, would you mind taking a look? The (previously) failing tests are still a bit baffling tbh. I would not have thought...