Dominic St-Pierre

Results 37 comments of Dominic St-Pierre

I've look at the changes re: your code formatter. I'd say if you'd like, you may add the config in this PR as well, really as you wish.

@claeusdev good question. In fact there's no reason at all why the mergeTags property is required. I've done a quick look at the code and it seems it _might_ be...

@claeusdev might be a good option yes, would prevent from having changes that do not relate to a PR but are just formatting. What are you using? Do you have...

Thank @muh-hizbe yes this is certainly something that would be helpful. I have no time at the moment to work on react-trix, but I'm happy to review / help anyone...

@claeusdev that's great. I don't have much preference to be honest. From what I understand, the toolbar configuration is done via the `Trix.config` if I'm not mistaken. I guess TrixEditor...

I'll try to check this for the next release, I just published v0.7.0. If someone want to tackle this one I'll be happy to review and publish an update.

Hey @airled I'm updating `react-trix` for the version 1.3.1 of `Trix` and I was looking at your issue regarding locale. Would the `onEditorReady` event which pass a reference the Trix's...

Hi @AlexHyslop I think you'll need to supply a firebase function where you'll handle the `multipart/form-data` to upload the file than upload to your firebase storage. If you can share...

I haven't tested this component from a server rendering scenario. I'm afraid I cannot help on that until I have some time to test this myself. Sorry for the delay,...

Yes good catch, the popup should also dismiss if we press the Escape key.