Daniel Stöckel
Daniel Stöckel
Nevertheless we should probably fix the test. I am not sure if this is an issue on the CI servers, but I imagine that randomly failing builds are no fun....
I think this looks pretty good. One suggestion I would like to make though is to use the FullNameType enum as bitflags that are used to build the combined flags:...
No need to be sorry, infinite loops simply should not happen ;-) However the problem does not seem to be in the SMILES parser, although it certainly has its flaws.
Okay to be maintainer
Resolved all comments. I had to use patches to avoid having to specify dependencies twice: in run and host. This is ready for another review round @conda-forge/staged-recipies
Adding to @nicornk: PEP-8 actually strongly discourages using `is` with boolean constants: ``` Don’t compare boolean values to True or False using ==: # Correct: if greeting: # Wrong: if...