David Stansby

Results 550 comments of David Stansby

> I think we should make the defaults exactly the same as they are in v2. @rabernat can you expand a bit on why you think we should keep the...

Thanks for the PR - is there any way we can install zlib-ng and test against it in our continuous integration? I'm wary about adding these new digests without actually...

It looks like there's a package on PyPI: https://pypi.org/project/zlib-ng/, so perhaps we could install that on Ubuntu and test the new digests using that?

Hmm, I'm not even getting the option to approve the workflow runs. Let me close and re-open this PR to see if that helps.

Ah, this is because we are in branch naming flux, and https://github.com/zarr-developers/zarr-python/pull/2349 needs to get in before we can run actions on the v2 branch. Sorry about this, when it's...

The motivation here was `zarr` follows SPEC 0, so won't (in theory) be supporting Python 3.8/3.9 now anyway, so it makes sense to mirror that here? Happy to change this...

👍 updated to just drop support for 3.8

Woop woop! In case you don't know about it already, https://github.com/scientific-python/pytest-doctestplus?tab=readme-ov-file#fixing-existing-docstrings might be helpful

It came in this rather large commit: https://github.com/zarr-developers/zarr-python/commit/4dc6f1f5046708648b5e6b82d0a64a24d1a40566. I think it's worth relying on `pydata-sphinx-theme` to set this to reduce the amount of custom CSS we have to maintain.