David Stansby
David Stansby
`NoMapsInFileError` could go in `sunpy.map`?
Thoughts on restricting this to be a `Unit` and not a `str`? My thinking is that `make_fitswcs_header` is meant to be a high level interface between Python objects and strings...
Instead of adding more arguments to `draw_grid()`, how about `draw_equator()` and `draw_meridian()` methods? These could then be used independently of `draw_grid()`, and avoids complicating the signature of `draw_grid()`.
No reason, other than I probably forgot. We should definitely do this.
Had a quick think about this, and instead of filling with `NaN` we should try and used masked arrays and set the mask. That way we're not limited to applying...
I'm just working on this, but it doesn't look like our current CDF test file has any masked values. @jgieseler can you recommend a small (in filesize) CDF file that...
Thanks! I think 300kB should be okay, and yes we should specifically test a file that has fillvalues in it
Just coming back to this, and sadly it looks like pandas doesn't have support for masking data 😢 However, once https://github.com/sunpy/sunpy/pull/5834 is merged we can mask the values in the...
The issue is that `NaN` is a floating point number, and there's no equivalent for integer data types. In `heliopy` I hacked this by converting all integer data type columns...
I'm going to re-open this as we only fixed it for floating point data types.