David Stansby
David Stansby
They do, but `NaN` is a floating point number, with no integer equivalent, so we can't set the masked values to `NaN` for integer data.
They do, but the point is to mask out that value so for e.g. plotting it doesn't show up.
> I say no. It makes sense for the LOS component, but it wouldn't make sense for the magnitude of the vector field. Agreed. What about adding `np.any(data < 0)...
I think this is a really good idea!
> Yeah, I think it's a great idea! Can we make it only show the message if a user (not a package) imports sunpy? To do this I think you...
I am 👍 to resolving this by recommending people writing clients raise a warning if the server they are querying is down, and by putting such warnings in the sunpy...
> I am interpreting this as you want to be able to set the download directory per-client in Fido. Correct, or per package (ie. a different directory for sunpy/heliopy). >...
Coming back to this now I'm writing some clients for `heliopy`, it would be nice to be able to specify a default download directory as an attribute of `UnifiedDownloaderFactory`, so...
Sorry, that was a bit stream of thought this morning, and I agree that multiple `UnifiedDownloaderFactory` weird... package agnostic would be good. Another thought I had was to allow clients...
General thoughts on this PR: - Can we get rid of the whitespace changes in the header files? They seem unnesseseary and make the PR harder to review - Can...