David Grieve

Results 24 comments of David Grieve

Will do. On 4/2/19 4:10 PM, Kevin Rushforth wrote: > > @dgrieve > > your input would be welcome if you have a few minutes to take a look >...

Did you consider changing the lookupFont method such that it never returns SKIP? lookupFont is an expensive little bugger since it considers all font, font-weight, font-size, and font-style styles up...

Some things to test that have caused issues in the past: * Popup inheriting styles from its owner. If you set a font or a font style on the owner,...

We should probably center on Google's style since it is IDE neutral, is actively maintained, and there are [reformatting tools](https://github.com/google/google-java-format) available.

grep for Finished in the gclogs test data and you'll see a ton of matching lines, none of which have a rule for matching. If you remove this line of...

Given the way DateTimeStamp is implemented, compareTo() will never be transitive. About the only thing that could be done is to throw away the ZonedDateTime part and just stick with...

@sumitsawant - About a week ago, @kirk-microsoft and I traced through this issue. The issue is more complex than a simple NPE and @kirk-microsoft is working on a fix.

I'll be frank here and state my opinion that what we have now for an API is unsatisfactory. The API is designed to support the Censum way of modeling which...