Douglas Senalik
Douglas Senalik
This pull request is now dependent on #1328 being merged first, so testing will fail until that happens.
@spficklin I actually created two basic automated tests for this loader, which previously had no tests. (Hopefully this can help with porting to tripal 4 eventually where we need full...
PHP8, empty tripal3 test site, adding a new organism, when select an empty ontology (i.e. no terms, ```project_relationship``` on an empty tripal3 site), I see this error from the ```schema__publication```...
The "weird bug" in https://github.com/tripal/tripal/pull/1267#pullrequestreview-1201494455 is a pre-existing bug. Most relationships are on content types named with just ```schema__name```. But others, such as organism, use something else, and ```schema__name``` does...
New issues noted in the "Relationship Table by Type" version: The grammar of the cv term is not formatted as nicely as in the "Relationship Statements", e.g. The following are...
To finish off review responses, I can see infraspecific name in organism add page  so @laceysanderson can you please try that again? The validation error may have been the...
The state of this pull request leaves organism relationships only fully working for Genus + species, infraspecific nomenclature only works if the Ajax callback sets the ```[id: xx]``` organism_id value....
@laceysanderson this "caveat" you noted is almost certainly due to the lack of infraspecific support in one spot, where only genus and species are queried in the organism table. I...
I have added this with https://github.com/tripal/tripal/pull/1267/commits/fa3e0a938da20bea8c0b606415866b4cfc1b695e and it now prevents this from happening  Note that I did not have to check for multiple matches, that is already caught elsewhere.
I am putting this here so I remember next year :yawning_face: If you use the relationship field to link two derived content types, e.g. **Genome Assembly** which is derived from...