David Bold

On 3/19/24 16:34, Peter Hill wrote: > ***@***.**** commented on this pull request. > > ------------------------------------------------------------------------ > > In include/bout/field.hxx > : > >> @@ -683,4 +683,12 @@ inline T...

The cuda build fails with: ```log /__w/BOUT-dev/BOUT-dev/src/field/field3d.cxx: In member function 'Options* Field3D::track(const T&, std::string)': /__w/BOUT-dev/BOUT-dev/src/field/field3d.cxx:851:63: error: expected ';' before '}' token 851 | (*tracking)[outname].setAttributes({ | ^ | ; /__w/BOUT-dev/BOUT-dev/src/field/field3d.cxx:851:64: error:...

> > It could be, but I don't think it is needed. I would personally keep it enabled for production runs, as it has a runtime switch, that is disabled...

> @dschwoerer After discussing this with @bendudson, we're quite concerned about the potential overhead of the temporary field dumping mechanism, both in terms of memory and performance, for what seems...

> Ok, I think we understand this a bit better now. I'd still be much happier if this was a macro and only turned on for `CHECK > 0`. I'm...

I think it is not so bad - if you know the sign of the offset, you can pick a specific one, otherwise the other. Even if it is not...

The logs have probably been deleted by now. Probably something to check after the next release. @ZedThree, do you mind checking after the next release? I imagine it could be...

I have uploaded v5.1.0: https://pypi.org/project/boutpp/5.1.0/

Oh, indeed, they are broken. How about this: ``` | Step 0 of 3. Elapsed 0:00:00.0 ETA 0:00:00.1 / Step 1 of 3. Elapsed 0:00:01.1 ETA 0:00:02.1 - Step 2...

@ZedThree The unit tests are failing, but I did not figure out what is wrong. I am thus hesitant to just change the expected values. The real code seems to...